Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add common logic to base envelope #35

Merged
merged 2 commits into from
Aug 15, 2022
Merged

refactor: add common logic to base envelope #35

merged 2 commits into from
Aug 15, 2022

Conversation

binbin-li
Copy link
Contributor

@binbin-li binbin-li commented Aug 12, 2022 •
edited
Loading

What?

  1. Add some shared logics from jws/cose envelope into the base envelope.
  2. Add post payload validation in Payload method.
  3. Add prior certificate chain validation in Sign method.
  4. Add prior payload validation in Verify method.
  5. Add exported method to get registered envelope types.

Signed-off-by: Binbin Li libinbin@microsoft.com

@binbin-li binbin-li force-pushed the refactor-common-logic branch 5 times, most recently from 44d50bd to 2d629f2 Compare August 12, 2022 08:27
@binbin-li
refactor: add common logic to base envelope
9977e37 
Signed-off-by: Binbin Li <libinbin@microsoft.com>
@binbin-li
feat: add payload and signerInfo verification in Verify
297487c 
Signed-off-by: Binbin Li <libinbin@microsoft.com>
@binbin-li binbin-li merged commit c515e7a into notaryproject:cose Aug 15, 2022
JeyJeyGao pushed a commit to JeyJeyGao/notation-core-go that referenced this pull request Sep 13, 2022
@binbin-li @JeyJeyGao
refactor: add common logic to base envelope (notaryproject#35)
168b611 
* refactor: add common logic to base envelope

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* feat: add payload and signerInfo verification in Verify

Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@binbin-li