Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add signature unit tests #43

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

binbin-li
Copy link
Contributor

@binbin-li binbin-li commented Aug 17, 2022

What?

  1. Add unit tests for signature submodule.
  2. Add unit tests for internal base envelope submodule.

Test coverage:
image

image

Signed-off-by: Binbin Li libinbin@microsoft.com

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Copy link

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin-li binbin-li merged commit a69de85 into notaryproject:cose Aug 19, 2022
JeyJeyGao pushed a commit to JeyJeyGao/notation-core-go that referenced this pull request Sep 13, 2022
* test: add signature unit tests

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* test: add tests for base envelope

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* test: add more valid cases

Signed-off-by: Binbin Li <libinbin@microsoft.com>

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants