fix: update envelope.Payload() logic #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JeyJeyGao
commented
Aug 18, 2022
•
JeyJeyGao
commented
- Payload() returns the raw payload context instead of base64 encoded data
- move extract algorithm step from Sign() to getSignedAttrs()
- wrap the parse error in a MalformedSignatureError
JeyJeyGao
force-pushed
the
junjiegao/add_jws
branch
2 times, most recently
from
5e87245
to
a66f1f5
Compare
chloeyin
reviewed
Aug 18, 2022
JeyJeyGao
force-pushed
the
junjiegao/add_jws
branch
2 times, most recently
from
79a397e
to
5b7a5dc
Compare
chloeyin
reviewed
Aug 18, 2022
Payload() returns the raw payload context instead of base64 encoded data Signed-off-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
JeyJeyGao
force-pushed
the
junjiegao/add_jws
branch
from
5b7a5dc
to
b3b9739
Compare
chloeyin
approved these changes
Aug 18, 2022
JeyJeyGao
added a commit
to JeyJeyGao/notation-core-go
that referenced
this pull request
Sep 13, 2022
Payload() returns the raw payload context instead of base64 encoded data Signed-off-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com> Signed-off-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.