refactor: refactor envelope and signer to support cose #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
force-pushed
the
refactor-signature
branch
2 times, most recently
from
c9741fb
to
981a49d
Compare
gokarnm
requested changes
Sep 12, 2022
shizhMSFT
reviewed
Sep 13, 2022
gokarnm
reviewed
Sep 13, 2022
gokarnm
reviewed
Sep 13, 2022
gokarnm
reviewed
Sep 13, 2022
gokarnm
reviewed
Sep 13, 2022
shizhMSFT
force-pushed
the
stage/cose
branch
from
56b3f7d
to
ca9f3f4
Compare
binbin-li
force-pushed
the
refactor-signature
branch
from
ff63555
to
432a293
Compare
binbin-li
force-pushed
the
refactor-signature
branch
4 times, most recently
from
84054cd
to
8a7286c
Compare
binbin-li
force-pushed
the
stage/cose
branch
from
ca9f3f4
to
65b1b6a
Compare
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
binbin-li
force-pushed
the
refactor-signature
branch
from
8a7286c
to
f5f9a79
Compare
shizhMSFT
reviewed
Sep 14, 2022
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
shizhMSFT
pushed a commit
that referenced
this pull request
Sep 21, 2022
Signed-off-by: Binbin Li <libinbin@microsoft.com>
patrickzheng200
pushed a commit
that referenced
this pull request
Sep 23, 2022
* Bump github.com/golang-jwt/jwt/v4 from 4.4.1 to 4.4.2 (#14) Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.1 to 4.4.2. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.4.1...v4.4.2) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor: refactor envelope and signer to support cose (#53) Signed-off-by: Binbin Li <libinbin@microsoft.com> * Revert "refactor: refactor envelope and signer to support cose (#53)" (#67) This reverts commit cbea2cf. Signed-off-by: Shiwei Zhang <shizh@microsoft.com> * update to go 1.18 (#66) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> * refactor: rename signer to signature submodule (#71) Signed-off-by: Binbin Li <libinbin@microsoft.com> * refactor: refactor envelope and signer to support cose (#73) Signed-off-by: Binbin Li <libinbin@microsoft.com> * feat: added COSE envelope implementation Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * update per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * resolve conflicts Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated conformance test Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * refactor: JWS for signature package (#76) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> * refactor: rename signer to signature submodule (#71) Signed-off-by: Binbin Li <libinbin@microsoft.com> * refactor: refactor envelope and signer to support cose (#73) Signed-off-by: Binbin Li <libinbin@microsoft.com> * refactor: JWS for signature package (#76) Signed-off-by: Junjie Gao <junjiegao@microsoft.com> * Allows signing with self-signed certificate (#77) Signed-off-by: Pritesh Bandi <pritesb@amazon.com> * updated conformance_test Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * refactor: refactor comments (#78) Signed-off-by: Binbin Li <libinbin@microsoft.com> * updated per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * updated per code review Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * removed CLI related maps, they should be in notation CLI Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> * resolved conflicts Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Binbin Li <libinbin@microsoft.com> Signed-off-by: Shiwei Zhang <shizh@microsoft.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Pritesh Bandi <pritesb@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Binbin Li <libinbin050215@gmail.com> Co-authored-by: Shiwei Zhang <shizh@microsoft.com> Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com> Co-authored-by: Binbin Li <libinbin@microsoft.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com>
chloeyin
added a commit
to notaryproject/notation-go
that referenced
this pull request
Sep 27, 2022
) ## What Refactor `notation-go` to support multiple envelope types. Background can be checked in notaryproject/notation#278 I wthe whole PR into two PRs to help review, this is the first PR. More unit test cases will be added in the next PR. The whole picture is here #146 ## Major Changes - Use package `github.com/notaryproject/notation-core-go/signature` to sign and verify. - Combine `runner` and `signer` into a `provider` for `pluginSigner` to sign and remove the `pluginSigProvider`. - Add `builtinProvider` to support local signing and `externalProvider` to support signing by plugin. - Move the payload media type and its checks to `signature` package as mentioned in notaryproject/notation-core-go#73 - Support new [keySpec](https://github.com/notaryproject/notaryproject/blob/main/signature-specification.md#algorithm-selection) and plugin contract. - Get verification plugin and version from extended attributes. - Add `SpeculateSignatureEnvelopeFormat` to inspect signature (This function may change later to better inspect a signature) - Add sign/verify from file test cases. Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com> Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com> Co-authored-by: zaihaoyin <zaihaoyin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Background can be checked out in notaryproject/notation#278
Envelopeinterface.SignatureProvidertoSigner.LocalSignerto support native signing implementation provided by underlying crypto libraries, e.g. go-cose, go-jwt.internal.base.Envelopestruct to replace the orginalSignatureEnvelopestruct.SignerInfotoEnvelopeContentto better reflect its functionality.Test?
Added corresponding unit tests.
Notes
The compilation failed right now, which should be addressed in the next PR.
Signed-off-by: Binbin Li libinbin@microsoft.com