Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add trustpolicy fuzzer #461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AdamKorcz
Copy link
Contributor

Moves this fuzzer upstream from cncf-fuzzing. Adds a dependency to randomize structs.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.34%. Comparing base (84c2ec0) to head (be49608).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   81.34%   81.34%           
=======================================
  Files          34       34           
  Lines        2578     2578           
=======================================
  Hits         2097     2097           
  Misses        335      335           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yizha1
Copy link
Contributor

yizha1 commented Sep 23, 2024

@AdamKorcz You may need to merge latest changes.

@AdamKorcz
Copy link
Contributor Author

@AdamKorcz You may need to merge latest changes.

done

@yizha1
Copy link
Contributor

yizha1 commented Sep 26, 2024

@AdamKorcz You may need to merge the latest changes and sign-off the commit again.

@AdamKorcz
Copy link
Contributor Author

@AdamKorcz You may need to merge the latest changes and sign-off the commit again.

done

Signed-off-by: Adam Korczynski <adam@adalogics.com>
@AdamKorcz
Copy link
Contributor Author

Have signed the commit.

@@ -3,6 +3,7 @@ module github.com/notaryproject/notation-go
go 1.22.0

require (
github.com/AdaLogics/go-fuzz-headers v0.0.0-20240806141605-e8a1dd7889d6
Copy link
Contributor

@Two-Hearts Two-Hearts Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is bringing in a new 3rd party dependency to notation-go.

@shizhMSFT @priteshbandi would like to know your thoughts regarding this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New dependency should not be added. If github.com/AdaLogics/go-fuzz-headers is really required for testing, we should create a nested model like https://github.com/notaryproject/notation/tree/main/test/e2e

@Two-Hearts Two-Hearts changed the title add trustpolicy fuzzer test: add trustpolicy fuzzer Sep 27, 2024
@@ -3,6 +3,7 @@ module github.com/notaryproject/notation-go
go 1.22.0

require (
github.com/AdaLogics/go-fuzz-headers v0.0.0-20240806141605-e8a1dd7889d6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New dependency should not be added. If github.com/AdaLogics/go-fuzz-headers is really required for testing, we should create a nested model like https://github.com/notaryproject/notation/tree/main/test/e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants