Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin)!: return cert chain in describe-key #187

Closed
wants to merge 1 commit into from

Conversation

shizhMSFT
Copy link
Contributor

Changes to SIGNATURE_GENERATOR.RAW capability:

  • Moved response.certificateChain from generate-signature to describe-key.
    • It is redundant to return the same certificate chain.
    • Simplifies the implementation of notation-core-go where certificate chain can be obtained without generating any signature.

Signed-off-by: Shiwei Zhang shizh@microsoft.com

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
Copy link
Contributor Author

@priteshbandi The keyId defined in the spec is the key identifier, which uniquely identifies the signing key. Rotating the signing key should not re-use the key id. Otherwise, we will have 1-to-many relationship for unique key IDs and signing keys. It is worth noting that key IDs should points to unique keys but key names are not.

@priteshbandi
Copy link
Contributor

Yes, keyId uniquely identifies a signing key at any given point in time. When keys are rotated, usually the old key is archived/disabled and a new key is actived so at any given time there is only one active key.

The keyId from the uber perspective is an alias to a local/remote key which needs to be unique in notation config only, it's out of the scope of notation to dictate or restrict how local/remote keys pointed by keyIds are updated/rotated.

@shizhMSFT
Copy link
Contributor Author

Closing as some cloud providers may silently rotate the key without changing the key id.

@shizhMSFT shizhMSFT closed this Aug 23, 2022
@dtzar dtzar modified the milestones: RC-1, alpha-4 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants