Add a helper function to create a mock contract. (cosmos#5162)

notional-labs · Nov 22, 2023 · 2bd29c0 · 2bd29c0
1 parent 0e3f428
commit 2bd29c0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/modules/light-clients/08-wasm/keeper/msg_server_test.go b/modules/light-clients/08-wasm/keeper/msg_server_test.go
@@ -68,7 +68,7 @@ func (suite *KeeperTestSuite) TestMsgStoreCode() {
 		{
 			"fails with wasm code too large",
 			func() {
-				msg = types.NewMsgStoreCode(signer, append(wasmtesting.WasmMagicNumber, []byte(ibctesting.GenerateString(uint(types.MaxWasmByteSize())))...))
+				msg = types.NewMsgStoreCode(signer, wasmtesting.CreateMockContract([]byte(ibctesting.GenerateString(uint(types.MaxWasmByteSize())))))
 			},
 			types.ErrWasmCodeTooLarge,
 		},
@@ -139,8 +139,7 @@ func (suite *KeeperTestSuite) TestMsgMigrateContract() {
 	oldChecksum, err := types.CreateChecksum(wasmtesting.Code)
 	suite.Require().NoError(err)
 
-	newByteCode := wasmtesting.WasmMagicNumber
-	newByteCode = append(newByteCode, []byte("MockByteCode-TestMsgMigrateContract")...)
+	newByteCode := wasmtesting.CreateMockContract([]byte("MockByteCode-TestMsgMigrateContract"))
 
 	govAcc := authtypes.NewModuleAddress(govtypes.ModuleName).String()
 
@@ -341,8 +340,7 @@ func (suite *KeeperTestSuite) TestMsgRemoveChecksum() {
 				expChecksums = []types.Checksum{}
 
 				for i := 0; i < 20; i++ {
-					mockCode := []byte{byte(i)}
-					mockCode = append(wasmtesting.WasmMagicNumber, mockCode...)
+					mockCode := wasmtesting.CreateMockContract([]byte{byte(i)})
 					checksum, err := types.CreateChecksum(mockCode)
 					suite.Require().NoError(err)
 

diff --git a/modules/light-clients/08-wasm/keeper/snapshotter_test.go b/modules/light-clients/08-wasm/keeper/snapshotter_test.go
@@ -15,7 +15,7 @@ import (
 )
 
 func (suite *KeeperTestSuite) TestSnapshotter() {
-	gzippedContract, err := types.GzipIt(append(wasmtesting.WasmMagicNumber, []byte("gzipped-contract")...))
+	gzippedContract, err := types.GzipIt(wasmtesting.CreateMockContract([]byte("gzipped-contract")))
 	suite.Require().NoError(err)
 
 	testCases := []struct {

diff --git a/modules/light-clients/08-wasm/testing/values.go b/modules/light-clients/08-wasm/testing/values.go
@@ -31,3 +31,8 @@ func CreateMockClientStateBz(cdc codec.BinaryCodec, checksum types.Checksum) []b
 	mockClientSate := types.NewClientState([]byte{1}, checksum, clienttypes.NewHeight(2000, 2))
 	return clienttypes.MustMarshalClientState(cdc, mockClientSate)
 }
+
+// CreateMockContract returns a well formed (magic number prefixed) wasm contract the given code.
+func CreateMockContract(code []byte) []byte {
+	return append(WasmMagicNumber, code...)
+}
diff --git a/modules/light-clients/08-wasm/types/migrate_contract_test.go b/modules/light-clients/08-wasm/types/migrate_contract_test.go
@@ -105,7 +105,7 @@ func (suite *TypesTestSuite) TestMigrateContract() {
 			var err error
 			oldHash, err = types.CreateChecksum(wasmtesting.Code)
 			suite.Require().NoError(err)
-			newHash, err = types.CreateChecksum(append(wasmtesting.WasmMagicNumber, []byte{1, 2, 3}...))
+			newHash, err = types.CreateChecksum(wasmtesting.CreateMockContract([]byte{1, 2, 3}))
 			suite.Require().NoError(err)
 
 			err = ibcwasm.Checksums.Set(suite.chainA.GetContext(), newHash)