nit: removed unused param from 'NewConsensusState' (cosmos#5159)

notional-labs · Nov 22, 2023 · 34f5798 · 34f5798
1 parent c54ec07
commit 34f5798
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/modules/light-clients/08-wasm/testing/wasm_endpoint.go b/modules/light-clients/08-wasm/testing/wasm_endpoint.go
@@ -30,7 +30,7 @@ func (endpoint *WasmEndpoint) CreateClient() error {
 	require.NoError(endpoint.Chain.TB, err)
 
 	clientState := types.NewClientState(contractClientState, checksum, clienttypes.NewHeight(0, 1))
-	consensusState := types.NewConsensusState(contractConsensusState, 0)
+	consensusState := types.NewConsensusState(contractConsensusState)
 
 	msg, err := clienttypes.NewMsgCreateClient(
 		clientState, consensusState, endpoint.Chain.SenderAccount.GetAddress().String(),

diff --git a/modules/light-clients/08-wasm/types/client_state_test.go b/modules/light-clients/08-wasm/types/client_state_test.go
@@ -309,7 +309,7 @@ func (suite *TypesTestSuite) TestInitialize() {
 			suite.Require().NoError(err)
 
 			clientState = types.NewClientState([]byte{1}, checksum, clienttypes.NewHeight(0, 1))
-			consensusState = types.NewConsensusState([]byte{2}, 0)
+			consensusState = types.NewConsensusState([]byte{2})
 
 			clientID := suite.chainA.App.GetIBCKeeper().ClientKeeper.GenerateClientIdentifier(suite.chainA.GetContext(), clientState.ClientType())
 			clientStore = suite.chainA.App.GetIBCKeeper().ClientKeeper.ClientStore(suite.chainA.GetContext(), clientID)

diff --git a/modules/light-clients/08-wasm/types/consensus_state.go b/modules/light-clients/08-wasm/types/consensus_state.go
@@ -9,7 +9,7 @@ import (
 var _ exported.ConsensusState = (*ConsensusState)(nil)
 
 // NewConsensusState creates a new ConsensusState instance.
-func NewConsensusState(data []byte, timestamp uint64) *ConsensusState {
+func NewConsensusState(data []byte) *ConsensusState {
 	return &ConsensusState{
 		Data: data,
 	}

diff --git a/modules/light-clients/08-wasm/types/consensus_state_test.go b/modules/light-clients/08-wasm/types/consensus_state_test.go
@@ -1,8 +1,6 @@
 package types_test
 
 import (
-	"time"
-
 	"github.com/cosmos/ibc-go/modules/light-clients/08-wasm/types"
 	"github.com/cosmos/ibc-go/v8/modules/core/exported"
 )
@@ -15,17 +13,17 @@ func (suite *TypesTestSuite) TestConsensusStateValidateBasic() {
 	}{
 		{
 			"success",
-			types.NewConsensusState([]byte("data"), uint64(time.Now().Unix())),
+			types.NewConsensusState([]byte("data")),
 			true,
 		},
 		{
 			"data is nil",
-			types.NewConsensusState(nil, uint64(time.Now().Unix())),
+			types.NewConsensusState(nil),
 			false,
 		},
 		{
 			"data is empty",
-			types.NewConsensusState([]byte{}, uint64(time.Now().Unix())),
+			types.NewConsensusState([]byte{}),
 			false,
 		},
 	}