imp(statemachine)!: if the allow all host messages wildcard is used, …

…then the allow list should have only one element (cosmos#5461)

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>

modules/apps/27-interchain-accounts/host/types/params.go

@@ -2,6 +2,7 @@ package types
 
 import (
 	"fmt"
+	"slices"
 	"strings"
 )
 
@@ -29,6 +30,10 @@ func (p Params) Validate() error {
 }
 
 func validateAllowlist(allowMsgs []string) error {
+	if slices.Contains(allowMsgs, AllowAllHostMsgs) && len(allowMsgs) > 1 {
+		return fmt.Errorf("allow list must have only one element because the allow all host messages wildcard (%s) is present", AllowAllHostMsgs)
+	}
+
 	for _, typeURL := range allowMsgs {
 		if strings.TrimSpace(typeURL) == "" {
 			return fmt.Errorf("parameter must not contain empty strings: %s", allowMsgs)

modules/apps/27-interchain-accounts/host/types/params_test.go

@@ -13,4 +13,5 @@ func TestValidateParams(t *testing.T) {
 	require.NoError(t, types.NewParams(false, []string{}).Validate())
 	require.Error(t, types.NewParams(true, []string{""}).Validate())
 	require.Error(t, types.NewParams(true, []string{" "}).Validate())
+	require.Error(t, types.NewParams(true, []string{"*", "/cosmos.bank.v1beta1.MsgSend"}).Validate())
 }