Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend_url option to client initializer #73

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

ludwigbacklund
Copy link
Contributor

@ludwigbacklund ludwigbacklund commented Mar 6, 2024

To use a custom backend URL, for example to be able to use the EU Novu API, you can pass a custom backend_url when initializing the client.

client = Novu::Client.new(
  access_token: '<your-novu-api_key>', 
  backend_url: 'https://eu.api.novu.co/v1'
)

@unicodeveloper
Copy link
Contributor

Thanks for submitting this PR @ludwigbacklund

@Eazybright Please can you help review this PR?

@Augustalex
Copy link

I also have this issue. Would be great if we can have this merged 🙏

Copy link
Contributor

@Eazybright Eazybright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unicodeveloper the PR is all good

@unicodeveloper unicodeveloper merged commit d221667 into novuhq:main Mar 7, 2024
@unicodeveloper
Copy link
Contributor

@ludwigbacklund Tests are failing. https://github.com/novuhq/novu-ruby/actions/runs/8188109840/job/22390018410#step:6:1294

Please can you send a PR to test this and ensure all the tests are passing. cc @Eazybright

@ludwigbacklund
Copy link
Contributor Author

@unicodeveloper #74

@unicodeveloper
Copy link
Contributor

@ludwigbacklund @Augustalex New release is live. Update your packages to v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants