Execute update sync #2476
Execute update sync #2476
Conversation
There was a problem hiding this comment.
Hey @smitpatel, couldn't sleep so went ahead and synced against dotnet/efcore#28834 (and dotnet/efcore#28782).
The original failing test passes, but there are three others which fail - see below. I pasted the actual emitted SQL into the baseline for you.
| """); | ||
| } | ||
|
|
||
| public override async Task Update_with_cross_join_cross_apply_set_constant(bool async) |
There was a problem hiding this comment.
Fails with invalid reference to FROM-clause entry for table "c"
| @@ -1121,6 +1210,72 @@ public override async Task Update_with_outer_apply_set_constant(bool async) | |||
| WHERE c.""CustomerID"" = t0.""CustomerID"""); | |||
| } | |||
|
|
|||
| public override async Task Update_with_cross_join_left_join_set_constant(bool async) | |||
There was a problem hiding this comment.
Fails with invalid reference to FROM-clause entry for table "c"
There was a problem hiding this comment.
So this does pass for Sqlite fine. (I guess Sqlite decided to defer from npgsql here). So looks like npgsql cannot use the table being updated in anywhere except for where predicate. This test is using it in join predicate for left join. This is something you may need to handle in provider given difference from Sqlite.
There was a problem hiding this comment.
OK @smitpatel, opened #2478 to track doing this on my side (will ping you when I get to it), and approved dotnet/efcore#28834. Thanks for looking at this.
| """); | ||
| } | ||
|
|
||
| public override async Task Update_with_cross_join_outer_apply_set_constant(bool async) |
There was a problem hiding this comment.
Fails with invalid reference to FROM-clause entry for table "c"
| @@ -1083,7 +1167,7 @@ public override async Task Update_with_cross_join_set_constant(bool async) | |||
| WHERE c.""CustomerID"" LIKE 'F%'"); | |||
| } | |||
|
|
|||
| [ConditionalTheory(Skip = "invalid reference to FROM-clause entry for table c")] | |||
| // [ConditionalTheory(Skip = "invalid reference to FROM-clause entry for table c")] | |||
|
Given #2508 is already merged, is there anymore blocking issues in core ExecuteUpdate functionality we need to get in rc2? |
|
Not AFAIK, thanks... There's still #2478 remaining but that's on my side. |
No description provided.