Skip to content

Commit

Permalink
send json errors to stderr, not stdout
Browse files Browse the repository at this point in the history
Fixes: #2150
Credit: @isaacs
Close: #2155
Reviewed-by: @ruyadorno
  • Loading branch information
isaacs authored and darcyclarke committed Nov 13, 2020
1 parent 6726319 commit 6d8d3cc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/utils/error-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ const errorHandler = (er) => {
detail: messageText(msg.detail),
},
}
console.log(JSON.stringify(error, null, 2))
console.error(JSON.stringify(error, null, 2))
}

exit(typeof er.errno === 'number' ? er.errno : typeof er.code === 'number' ? er.code : 1)
Expand Down
6 changes: 3 additions & 3 deletions test/lib/utils/error-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ t.test('console.log output using --json', (t) => {

config.values.json = true

const _log = console.log
console.log = (jsonOutput) => {
const _error = console.error
console.error = (jsonOutput) => {
t.deepEqual(
JSON.parse(jsonOutput),
{
Expand All @@ -236,7 +236,7 @@ t.test('console.log output using --json', (t) => {
errorHandler(new Error('Error: EBADTHING Something happened'))

t.teardown(() => {
console.log = _log
console.error = _error
delete config.values.json
})
})
Expand Down

0 comments on commit 6d8d3cc

Please sign in to comment.