fix: remove incompatible params from ci (#6322)

npm · Apr 18, 2023 · f4e73ab · f4e73ab
1 parent 997bcdf
commit f4e73ab
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 14 deletions.
diff --git a/lib/commands/ci.js b/lib/commands/ci.js
@@ -6,13 +6,27 @@ const log = require('../utils/log-shim.js')
 const validateLockfile = require('../utils/validate-lockfile.js')
 
 const ArboristWorkspaceCmd = require('../arborist-cmd.js')
-const Install = require('./install.js')
 
 class CI extends ArboristWorkspaceCmd {
   static description = 'Clean install a project'
   static name = 'ci'
 
-  static params = Install.params
+  // These are in the order they will show up in when running "-h"
+  static params = [
+    'install-strategy',
+    'legacy-bundling',
+    'global-style',
+    'omit',
+    'strict-peer-deps',
+    'package-lock',
+    'foreground-scripts',
+    'ignore-scripts',
+    'audit',
+    'bin-links',
+    'fund',
+    'dry-run',
+    ...super.params,
+  ]
 
   async exec () {
     if (this.npm.global) {

diff --git a/lib/commands/install.js b/lib/commands/install.js
@@ -16,6 +16,7 @@ class Install extends ArboristWorkspaceCmd {
   static name = 'install'
 
   // These are in the order they will show up in when running "-h"
+  // If adding to this list, consider adding also to ci.js
   static params = [
     'save',
     'save-exact',

diff --git a/smoke-tests/tap-snapshots/test/index.js.test.cjs b/smoke-tests/tap-snapshots/test/index.js.test.cjs
@@ -55,8 +55,6 @@ npm ERR! Usage:
 npm ERR! npm ci
 npm ERR! 
 npm ERR! Options:
-npm ERR! [-S|--save|--no-save|--save-prod|--save-dev|--save-optional|--save-peer|--save-bundle]
-npm ERR! [-E|--save-exact] [-g|--global]
 npm ERR! [--install-strategy <hoisted|nested|shallow|linked>] [--legacy-bundling]
 npm ERR! [--global-style] [--omit <dev|optional|peer> [--omit <dev|optional|peer> ...]]
 npm ERR! [--strict-peer-deps] [--no-package-lock] [--foreground-scripts]

diff --git a/tap-snapshots/test/lib/docs.js.test.cjs b/tap-snapshots/test/lib/docs.js.test.cjs
@@ -2210,8 +2210,6 @@ Usage:
 npm ci
 
 Options:
-[-S|--save|--no-save|--save-prod|--save-dev|--save-optional|--save-peer|--save-bundle]
-[-E|--save-exact] [-g|--global]
 [--install-strategy <hoisted|nested|shallow|linked>] [--legacy-bundling]
 [--global-style] [--omit <dev|optional|peer> [--omit <dev|optional|peer> ...]]
 [--strict-peer-deps] [--no-package-lock] [--foreground-scripts]
@@ -2229,9 +2227,6 @@ npm ci
 aliases: clean-install, ic, install-clean, isntall-clean
 \`\`\`
 
-#### \`save\`
-#### \`save-exact\`
-#### \`global\`
 #### \`install-strategy\`
 #### \`legacy-bundling\`
 #### \`global-style\`
@@ -2811,8 +2806,6 @@ Usage:
 npm install-ci-test
 
 Options:
-[-S|--save|--no-save|--save-prod|--save-dev|--save-optional|--save-peer|--save-bundle]
-[-E|--save-exact] [-g|--global]
 [--install-strategy <hoisted|nested|shallow|linked>] [--legacy-bundling]
 [--global-style] [--omit <dev|optional|peer> [--omit <dev|optional|peer> ...]]
 [--strict-peer-deps] [--no-package-lock] [--foreground-scripts]
@@ -2830,9 +2823,6 @@ npm install-ci-test
 aliases: cit, clean-install-test, sit
 \`\`\`
 
-#### \`save\`
-#### \`save-exact\`
-#### \`global\`
 #### \`install-strategy\`
 #### \`legacy-bundling\`
 #### \`global-style\`