fix: don't break up log message across lines

npm · Mar 30, 2023 · fbb6e94 · fbb6e94
1 parent 68bf5f3
commit fbb6e94
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/lib/utils/exit-handler.js b/lib/utils/exit-handler.js
@@ -5,8 +5,6 @@ const log = require('./log-shim.js')
 const errorMessage = require('./error-message.js')
 const replaceInfo = require('./replace-info.js')
 
-const indent = (val) => Array.isArray(val) ? val.map(v => indent(v)) : `    ${val}`
-
 let npm = null // set by the cli
 let exitHandlerCalled = false
 let showLogFileError = false
@@ -73,15 +71,15 @@ process.on('exit', code => {
       const message = []
 
       if (timingFile) {
-        message.push('Timing info written to:', indent(timingFile))
+        message.push(`Timing info written to: ${timingFile}`)
       } else if (timing) {
         message.push(
           `The timing file was not written due to an error writing to the directory: ${timingDir}`
         )
       }
 
       if (logFiles.length) {
-        message.push('A complete log of this run can be found in:', ...indent(logFiles))
+        message.push(`A complete log of this run can be found in: ${logFiles}`)
       } else if (logsMax <= 0) {
         // user specified no log file
         message.push(`Log files were not written due to the config logs-max=${logsMax}`)

diff --git a/smoke-tests/tap-snapshots/test/index.js.test.cjs b/smoke-tests/tap-snapshots/test/index.js.test.cjs
@@ -68,8 +68,7 @@ npm ERR! aliases: clean-install, ic, install-clean, isntall-clean
 npm ERR! 
 npm ERR! Run "npm help ci" for more info
 
-npm ERR! A complete log of this run can be found in:
-
+npm ERR! A complete log of this run can be found in: {NPM}/{TESTDIR}/cache/_logs/{LOG}
 `
 
 exports[`test/index.js TAP basic npm diff > should have expected diff output 1`] = `

diff --git a/smoke-tests/test/fixtures/setup.js b/smoke-tests/test/fixtures/setup.js
@@ -124,7 +124,7 @@ module.exports = async (t, { testdir = {}, debug } = {}) => {
       .replace(/\r\n/g, '\n')
       .replace(/ \(in a browser\)/g, '')
       .replace(/^npm@.* /gm, 'npm ')
-      .replace(/^.*debug-[0-9]+.log$/gm, '')
+      .replace(/[0-9TZ_-]*debug-[0-9]+.log$/gm, '{LOG}')
       .replace(/in \d+[ms]+$/gm, 'in {TIME}')
   }
   const log = (...a) => debugLog(cleanOutput(a.join(' ')))

diff --git a/tap-snapshots/test/lib/utils/exit-handler.js.test.cjs b/tap-snapshots/test/lib/utils/exit-handler.js.test.cjs
@@ -32,8 +32,7 @@ XX error ERR DETAIL Unknown error
 XX verbose exit 1
 XX timing npm Completed in {TIME}ms
 XX verbose code 1
-XX error A complete log of this run can be found in:
-XX error     {CWD}/cache/_logs/{DATE}-debug-0.log
+XX error A complete log of this run can be found in: {CWD}/cache/_logs/{DATE}-debug-0.log
 `
 
 exports[`test/lib/utils/exit-handler.js TAP handles unknown error with logs and debug file > logs 1`] = `
@@ -63,6 +62,5 @@ error ERR DETAIL Unknown error
 verbose exit 1
 timing npm Completed in {TIME}ms
 verbose code 1
-error  A complete log of this run can be found in:
-    {CWD}/cache/_logs/{DATE}-debug-0.log
+error  A complete log of this run can be found in: {CWD}/cache/_logs/{DATE}-debug-0.log
 `