Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exec workspaces #2886

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Mar 17, 2021

Add workspaces support to npm exec

  • Refactored logic to read and filter workspaces into
    lib/workspaces/get-workspaces.js
  • Added location context message when entering interactive
    shell using npm exec (with no args)
  • Add ability to execute a package in the context of each
    configured workspace

Fixes: npm/statusboard#288

@ruyadorno ruyadorno requested a review from a team as a code owner March 17, 2021 04:27
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:minor new backwards-compatible feature pr: needs documentation pull request requires docs before merging and removed pr: needs documentation pull request requires docs before merging labels Mar 17, 2021
@ruyadorno ruyadorno changed the title Add exec workspaces feat: add exec workspaces Mar 18, 2021
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We know we are going to be iterating on these more. This gets it implemented and tested.

@ruyadorno ruyadorno changed the base branch from latest to release-next March 19, 2021 16:05
Add workspaces support to `npm exec`
  - Refactored logic to read and filter workspaces into
  `lib/workspaces/get-workspaces.js`
  - Added location context message when entering interactive
  shell using `npm exec` (with no args)
  - Add ability to execute a package in the context of each
  configured workspace

Fixes: npm/statusboard#288

PR-URL: npm#2886
Credit: @ruyadorno
Close: npm#2886
Reviewed-by: @wraithgar
@wraithgar wraithgar merged commit e1b3b31 into npm:release-next Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:minor new backwards-compatible feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task(workspaces): update exec
2 participants