Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): should not use package-lock config #4364

Merged

Conversation

ruyadorno
Copy link
Contributor

npm ci should never be affected by the package-lock config.

References

Fixes: #4185

@ruyadorno ruyadorno requested a review from a team as a code owner February 3, 2022 03:46
@ruyadorno ruyadorno added Release 8.x work is associated with a specific npm 8 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Feb 3, 2022
@wraithgar
Copy link
Member

Can we add a test?

@ruyadorno
Copy link
Contributor Author

Can we add a test?

I'll add a check alongside the one we have to validate that save=false

`npm ci` should never be affected by the `package-lock` config.

Fixes: npm#4185
@ruyadorno ruyadorno force-pushed the npm-ci-ignore-package-lock-config branch from f9f6a63 to 7ddec04 Compare February 3, 2022 15:39
@ruyadorno ruyadorno merged commit c0519ed into npm:release-next Feb 3, 2022
@ruyadorno ruyadorno mentioned this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants