Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arborist): pass the edge to fromPath in order to determine correct path #5233

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Jul 28, 2022

by passing in the edge we can determine if the edge is overridden, and if it is the path we want to return is the project root since that's what user's will have define their overrides relative to

builds on #5227, land that first
closes #4397

@nlf nlf requested a review from a team as a code owner July 28, 2022 18:48
@nlf nlf changed the title nlf/fix file spec overrides fix(arborist): pass the edge to fromPath in order to determine correct path Jul 28, 2022
…t path

by passing in the edge we can determine if the edge is overridden, and if it is the path we want to return is the project root since that's what user's will have define their overrides relative to
@nlf nlf force-pushed the nlf/fix-file-spec-overrides branch from ab9904b to a24268a Compare August 1, 2022 18:13
@nlf nlf merged commit 050284d into latest Aug 1, 2022
@nlf nlf deleted the nlf/fix-file-spec-overrides branch August 1, 2022 18:20
@nlf nlf mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm update fails when overriding dependency of local file with local file
2 participants