Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting for #5225 #5323

Merged
merged 9 commits into from
Aug 22, 2022
Merged

Linting for #5225 #5323

merged 9 commits into from
Aug 22, 2022

Conversation

wraithgar
Copy link
Member

This updates linting on all the repos except for docs that fail due to #5225.

Landing this (rebase and merge) will also land #5225. These should go together.

lukekarrys and others added 6 commits August 18, 2022 07:11
It's used in tests so it needs to be in the manifest
It's used in tests so it needs to be in the manifest
It's used in tests so it needs to be in the manifest
@wraithgar wraithgar requested a review from a team as a code owner August 18, 2022 18:20
@wraithgar
Copy link
Member Author

#5309 Should probably land first too because linting errors in docs are in files that will go away once that lands.

@lukekarrys
Copy link
Contributor

lukekarrys commented Aug 18, 2022

I think this should go before #5309. I think the easiest way for that to happen and avoid conflicts is create a docs/.eslintrc.local.json files that turns off the one failure there with this config:

{ "rules": { "import/no-extraneous-dependencies": "off" } }

And then as part of #5309 I will remove that config.

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Aug 18, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.560 ±0.96 15.962 ±0.01 14.240 ±0.04 17.376 ±1.79 2.524 ±0.01 2.526 ±0.02 2.057 ±0.01 9.868 ±0.04 2.063 ±0.01 2.970 ±0.01
#5323 39.700 ±3.60 15.870 ±0.05 14.188 ±0.05 16.162 ±0.07 2.497 ±0.04 2.501 ±0.01 2.050 ±0.00 9.767 ±0.03 2.057 ±0.02 3.230 ±0.32
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 28.097 ±1.69 12.263 ±0.02 10.719 ±0.00 11.856 ±0.77 2.347 ±0.03 2.342 ±0.00 2.100 ±0.01 7.221 ±0.00 1.981 ±0.01 2.742 ±0.05
#5323 27.660 ±0.55 12.130 ±0.22 10.593 ±0.02 11.616 ±0.34 2.359 ±0.04 2.312 ±0.00 2.120 ±0.07 7.231 ±0.02 1.958 ±0.01 3.021 ±0.50

In preparation for @npmcli/eslint-config@3.1.0
In preparation for @npmcli/eslint-config@3.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants