Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: linked-strategy lifecycle missing bins #6175

Merged
merged 2 commits into from
Feb 21, 2023
Merged

fix: linked-strategy lifecycle missing bins #6175

merged 2 commits into from
Feb 21, 2023

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Feb 16, 2023 •
edited
Loading

  • in --install-strategy=linked some dependencies hadn't linked their bins by the time lifecycle scripts ran
  • store link nodes were unnecessarily running lifecycle scripts

@fritzy fritzy requested a review from a team as a code owner February 16, 2023 12:24
@fritzy fritzy requested review from wraithgar and removed request for a team February 16, 2023 12:24
@fritzy fritzy changed the title fix: fixed linked installs lifecycle batching order, no lifecycle scripts on store links fix: linked-strategy lifecycle missing bins Feb 16, 2023
wraithgar
wraithgar approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a comment about why store nodes got at the end of the depNodes set.

@fritzy
Copy link
Contributor Author

fritzy commented Feb 21, 2023

This can be squashed.

@wraithgar wraithgar merged commit 6ed3535 into latest Feb 21, 2023
@wraithgar wraithgar deleted the fritzy/fix-linked-bins branch February 21, 2023 22:12
@github-actions github-actions bot mentioned this pull request Feb 21, 2023
Merged
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzy @wraithgar