Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send options with grant/revoke requests #6211

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

DavidTanner
Copy link
Contributor

Without the flatOptions the npmrc file isn't used to grant permissions, and access can't be changed.

References

Fixes #6210

@DavidTanner DavidTanner requested a review from a team as a code owner February 28, 2023 20:41
@DavidTanner DavidTanner requested review from nlf and removed request for a team February 28, 2023 20:41
@DavidTanner
Copy link
Contributor Author

@fritzy I updated the commit and need to re-run build.

@fritzy
Copy link
Contributor

fritzy commented Mar 2, 2023

@DavidTanner can you add a test that shows this fixing the issue, and reference the issue in a comment? Otherwise, I'll try to get to it the week after next.

@DavidTanner
Copy link
Contributor Author

@fritzy Added to the existing tests.

@lukekarrys lukekarrys changed the title Send options with grant/revoke requests fix: send options with grant/revoke requests Mar 8, 2023
@lukekarrys lukekarrys merged commit e455e3f into npm:latest Mar 8, 2023
@github-actions github-actions bot mentioned this pull request Mar 8, 2023
@DavidTanner DavidTanner deleted the fixAccessCommands branch March 8, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm access commands not sending auth token
3 participants