Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make all color output use an npm instance of chalk #6284

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner March 23, 2023 23:13
@lukekarrys lukekarrys requested review from wraithgar and removed request for a team March 23, 2023 23:13
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Mar 23, 2023

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 45.309 ±2.66 26.401 ±1.21 24.734 ±0.19 27.211 ±0.21 4.267 ±0.11 4.193 ±0.09 3.246 ±0.01 16.894 ±0.35 3.252 ±0.00 4.986 ±0.36 0.674 ±0.02 0.695 ±0.03
#6284 46.083 ±2.13 26.561 ±0.53 24.704 ±0.86 28.133 ±0.15 4.329 ±0.02 4.320 ±0.07 3.449 ±0.00 17.117 ±0.24 3.446 ±0.11 4.880 ±0.21 0.668 ±0.00 0.701 ±0.04
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 33.061 ±1.09 19.862 ±0.23 18.833 ±0.79 19.169 ±0.19 3.901 ±0.08 3.951 ±0.01 3.384 ±0.02 12.618 ±0.04 3.291 ±0.05 4.522 ±0.07 0.697 ±0.01 0.698 ±0.02
#6284 31.533 ±0.82 19.964 ±0.66 17.890 ±0.04 19.755 ±0.59 4.049 ±0.02 3.875 ±0.12 3.313 ±0.00 12.555 ±0.19 3.206 ±0.03 4.474 ±0.11 0.669 ±0.00 0.692 ±0.01

@@ -78,7 +78,7 @@ class Explain extends ArboristWorkspaceCmd {
this.npm.output(JSON.stringify(expls, null, 2))
} else {
this.npm.output(expls.map(expl => {
return explainNode(expl, Infinity, this.npm.color)
return explainNode(expl, Infinity, this.npm.chalk)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it wise to call it "chalk" when it may be best to migrate off of that package in the future?

@wraithgar wraithgar merged commit 09b58e4 into latest Mar 29, 2023
@wraithgar wraithgar deleted the lk/chalk branch March 29, 2023 20:00
@github-actions github-actions bot mentioned this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants