Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tests for zlib differences between node versions #7040

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Nov 30, 2023

Most of npm's tests are built around the fact that zlib is not deterministic, but it looks like for some small code paths it had been so far and those tests were still using static fixtures. Enough changed in the latest node version to force the remaining tests we have w/ shasum fixtures to fail.

Good explanation at nodejs/node#50138

@wraithgar wraithgar requested a review from a team as a code owner November 30, 2023 22:00
@wraithgar wraithgar marked this pull request as draft November 30, 2023 22:01
@lukekarrys
Copy link
Contributor

Does this need to land first so other PRs will pass CI?

@wraithgar wraithgar merged commit 4ba585c into latest Dec 1, 2023
19 checks passed
@wraithgar wraithgar deleted the gar/zlib-tests branch December 1, 2023 17:29
@github-actions github-actions bot mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants