storybookConfigurationGenerator appending to nx.json ad nauseam

[matthew-williamson]

Current Behavior

When using the storybookConfigurationGenerator from @nx/react, my workspace's nx.json file gets an additional tasksRunnerOptions.default.options.cacheableOperations build-storybook value every single time, meaning it eventually looks like

{
  "tasksRunnerOptions": {
    "default": {
      "options": {
        "cacheableOperations": ["build-storybook", "build-storybook", "build-storybook", ...]
      }
    }
  }
}

Expected Behavior

It should not be doing that, if the generator or update of the tree or files or whatever is causing it sees the value in the nx.json array, it shouldn't add a new one.

GitHub Repo

No response

Steps to Reproduce

1. Run the storybookConfigurationGenerator

Nx Report

N/A

Failure Logs

No response

Package Manager Version

yarn 3.1.1

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

No response

[Coly010]

@matthew-williamson Can you please provide the Nx version you're using by running nx report because this should have been fixed already:

nx/packages/storybook/src/generators/configuration/lib/util-functions.ts

Line 639 in 590c7ae

nxJson.tasksRunnerOptions?.default?.options?.cacheableOperations &&

[matthew-williamson]

@Coly010 ah, I see. Totally possible:

[Coly010]

Interestingly, you’re on a version that fix exists for.

I see you have a local workspace plugin, are you invoking storybookConfigurationGenerator from this plugin?

[jrschifa]

I think this PR is the culprit that broke the comparison. 05e7602#diff-2cc24f7df8a70ad01ff5f9e420bd92c04b86adda2ee5005bce9aa5a165ab0147L137-L145

Simply missing a ! in front of the check in storybook/src/generators/init/init.js

[Coly010]

@jrschifa Ah! good spot. I'll get it resolved