Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nx-cloud): improve nx agents feature page #27606

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

juristr
Copy link
Member

@juristr juristr commented Aug 22, 2024

@juristr juristr requested a review from a team as a code owner August 22, 2024 21:02
@juristr juristr requested a review from jaysoo August 22, 2024 21:02
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 4, 2024 1:46pm

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Nx Agents are plural
  • Clearly state the main point of the page at the beginning
  • Agents picking up stacked tasks metaphor was explained backwards

docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some more grammar/typos. Looks good after that

docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
docs/shared/features/distribute-task-execution.md Outdated Show resolved Hide resolved
@juristr juristr merged commit 10b9051 into master Sep 4, 2024
5 of 6 checks passed
@juristr juristr deleted the docs/fpci-nx-agents branch September 4, 2024 13:44
ZackDeRose pushed a commit to ZackDeRose/nx that referenced this pull request Sep 6, 2024
FrozenPandaz pushed a commit that referenced this pull request Sep 6, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants