GH-153 - ConflictingArgumentAssignmentsAnalyzer fixes

nsubstitute · Oct 2, 2022 · 154a51a · 154a51a
1 parent 3880997
commit 154a51a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...te.Analyzers.Shared/DiagnosticAnalyzers/AbstractConflictingArgumentAssignmentsAnalyzer.cs b/...te.Analyzers.Shared/DiagnosticAnalyzers/AbstractConflictingArgumentAssignmentsAnalyzer.cs
@@ -57,14 +57,14 @@ private void AnalyzeInvocation(OperationAnalysisContext syntaxNodeContext)
 
         var previousCallIndexers = FindCallInfoIndexers(substituteOperation);
 
-        var immutableHashSet = previousCallIndexers
+        var previousCallIndexerPositions = previousCallIndexers
             .Select(indexerPropertyReferenceOperation => indexerPropertyReferenceOperation.GetIndexerPosition())
             .ToImmutableHashSet();
 
         foreach (var indexerExpressionSyntax in andDoesIndexers)
         {
             var position = indexerExpressionSyntax.GetIndexerPosition();
-            if (position.HasValue && immutableHashSet.Contains(position.Value))
+            if (position.HasValue && previousCallIndexerPositions.Contains(position.Value))
             {
                 syntaxNodeContext.ReportDiagnostic(Diagnostic.Create(
                     DiagnosticDescriptorsProvider.ConflictingArgumentAssignments,
@@ -81,7 +81,7 @@ private IEnumerable<IOperation> FindCallInfoIndexers(IInvocationOperation invoca
             foreach (var propertyReference in _callInfoFinder
                          .GetCallInfoContext(argumentOperation).IndexerAccessesOperations)
             {
-                if (propertyReference.Parent is ISimpleAssignmentOperation)
+                if (propertyReference is IPropertyReferenceOperation && propertyReference.Parent is ISimpleAssignmentOperation)
                 {
                     yield return propertyReference;
                 }