[GH-61] - proper checks for extension methods call

nsubstitute · Jan 27, 2019 · 9f52c20 · 9f52c20
1 parent 628ce4c
commit 9f52c20
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/NSubstitute.Analyzers.CSharp/DiagnosticAnalyzers/CallInfoAnalyzer.cs b/src/NSubstitute.Analyzers.CSharp/DiagnosticAnalyzers/CallInfoAnalyzer.cs
@@ -28,7 +28,7 @@ public CallInfoAnalyzer()
 
         protected override SyntaxNode GetSubstituteCall(IMethodSymbol methodSymbol, InvocationExpressionSyntax invocationExpressionSyntax)
         {
-            if (methodSymbol.IsStatic)
+            if (methodSymbol.IsExtensionMethod)
             {
                 switch (methodSymbol.MethodKind)
                 {

diff --git a/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractCallInfoAnalyzer.cs b/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractCallInfoAnalyzer.cs
@@ -270,7 +270,7 @@ private bool SupportsCallInfo(SyntaxNodeAnalysisContext syntaxNodeContext, TInvo
             var allArguments = GetArgumentExpressions(syntax);
             var argumentsForAnalysis = methodSymbol.MethodKind == MethodKind.ReducedExtension
                 ? allArguments
-                : methodSymbol.IsStatic ? allArguments.Skip(1) : allArguments;
+                : methodSymbol.IsExtensionMethod ? allArguments.Skip(1) : allArguments;
 
             if (MethodNames.TryGetValue(methodSymbol.Name, out var typeName) == false)
             {

diff --git a/src/NSubstitute.Analyzers.VisualBasic/DiagnosticAnalyzers/CallInfoAnalyzer.cs b/src/NSubstitute.Analyzers.VisualBasic/DiagnosticAnalyzers/CallInfoAnalyzer.cs
@@ -28,7 +28,7 @@ public CallInfoAnalyzer()
 
         protected override SyntaxNode GetSubstituteCall(IMethodSymbol methodSymbol, InvocationExpressionSyntax invocationExpressionSyntax)
         {
-            if (methodSymbol.IsStatic)
+            if (methodSymbol.IsExtensionMethod)
             {
                 switch (methodSymbol.MethodKind)
                 {

diff --git a/...rs.Tests.VisualBasic/DiagnosticAnalyzersTests/CallInfoAnalyzerTests/AndDoesMethodTests.cs b/...rs.Tests.VisualBasic/DiagnosticAnalyzersTests/CallInfoAnalyzerTests/AndDoesMethodTests.cs
@@ -3,7 +3,7 @@
 
 namespace NSubstitute.Analyzers.Tests.VisualBasic.DiagnosticAnalyzersTests.CallInfoAnalyzerTests
 {
-    [CombinatoryData("Returns", "ReturnsForAnyArgs")]
+    [CombinatoryData("AndDoes")]
     public class AndDoesMethodTests : CallInfoDiagnosticVerifier
     {
         public override async Task ReportsNoDiagnostics_WhenSubstituteMethodCannotBeInferred(string method, string call, string argAccess)

diff --git a/...ute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/VisualBasicDiagnosticVerifier.cs b/...ute.Analyzers.Tests.VisualBasic/DiagnosticAnalyzersTests/VisualBasicDiagnosticVerifier.cs
@@ -20,7 +20,7 @@ public abstract class VisualBasicDiagnosticVerifier : DiagnosticVerifier
 
         protected override CompilationOptions GetCompilationOptions()
         {
-            return new VisualBasicCompilationOptions(OutputKind.DynamicallyLinkedLibrary, optionStrict: OptionStrict.On);
+            return new VisualBasicCompilationOptions(OutputKind.DynamicallyLinkedLibrary, optionStrict: OptionStrict.Off);
         }
 
         protected override IEnumerable<MetadataReference> GetAdditionalMetadataReferences()