Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-142] - adding simplified InternalsVisibleTo("DynamicProxyGenAssembly2") when System.Runtime.CompilerServices in scope #143

Merged
merged 1 commit into from
Mar 27, 2020
Merged

[GH-142] - adding simplified InternalsVisibleTo("DynamicProxyGenAssembly2") when System.Runtime.CompilerServices in scope #143

merged 1 commit into from
Mar 27, 2020

Conversation

tpodolak
Copy link
Member

Closes #142

@coveralls
Copy link

coveralls commented Mar 25, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 394

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 95.81%
Totals Coverage Status
Change from base Build 391: -0.02%
Covered Lines: 2424
Relevant Lines: 2530
💛 - Coveralls

dtchepak
dtchepak approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor suggestions, but I think is fine to merge as is. 👍

src/NSubstitute.Analyzers.CSharp/Refactorings/AddInternalsVisibleToAttributeRefactoring.cs Outdated Show resolved Hide resolved
src/NSubstitute.Analyzers.Shared/Extensions/ObjectExtensions.cs Outdated Show resolved Hide resolved
src/NSubstitute.Analyzers.Shared/Extensions/SyntaxGeneratorExtensions.cs Show resolved Hide resolved
@tpodolak tpodolak force-pushed the GH-142-simplify-internalsvisibleto branch from e13d04a to 7d37760 Compare March 26, 2020 21:51
@tpodolak
[GH-142] - adding simplified InternalsVisibleTo("DynamicProxyGenAssem…
d18ec65 
…bly2") when System.Runtime.CompilerServices in scope
@tpodolak tpodolak force-pushed the GH-142-simplify-internalsvisibleto branch from 7d37760 to d18ec65 Compare March 26, 2020 22:10
@tpodolak
Copy link
Member Author

tpodolak commented Mar 26, 2020 •
edited
Loading

Very minor suggestions, but I think is fine to merge as is.

@dtchepak comments fixed/answered, please check if everything is fine

dtchepak
dtchepak approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me 👍

@tpodolak tpodolak merged commit 7ac8b34 into dev Mar 27, 2020
@tpodolak tpodolak deleted the GH-142-simplify-internalsvisibleto branch March 27, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtchepak dtchepak dtchepak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NS1003 fix provider - simplify InternalVisibilityTo when System.Runtime.CompilerServices in scope
3 participants
@tpodolak @coveralls @dtchepak