Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py: tests: make tests run under PyPy #158

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

zougloub
Copy link
Contributor

Closes #157

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Merging #158 (ad1c62f) into main (b348312) will increase coverage by 0.32%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   87.40%   87.73%   +0.32%     
==========================================
  Files          24       24              
  Lines        1604     1622      +18     
  Branches       74       79       +5     
==========================================
+ Hits         1402     1423      +21     
- Misses        184      185       +1     
+ Partials       18       14       -4     

@MatthieuDartiailh
Copy link
Member

I am confused as to why PyPy stopped using the qualname. But given this does not affect the correctness of the code I am fine with relaxing the tests. Thanks for the PR

@MatthieuDartiailh MatthieuDartiailh merged commit 26051dd into nucleic:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail on pypy
3 participants