Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/move to common build #5

Merged
merged 14 commits into from
Nov 18, 2020
Merged

Fix/move to common build #5

merged 14 commits into from
Nov 18, 2020

Conversation

Mpdreamz
Copy link
Contributor

@Mpdreamz Mpdreamz commented May 15, 2020

This moves the build over to the common build pattern in nullean, ecs-dotnet, elastic-transport.

Moves the SDK over to .NET 5.0

This now no longer hides System.Reactive, the build had to be run under windows for ILRepack to work and properly resign. Dependency free is nice but not worth spending weeks over trying to get there.

This also bumps the base TFM to net461 this falls in line with other repositories

@Mpdreamz
Copy link
Contributor Author

The dependency listing turned out be a bug in npkg-validator nullean/nupkg-validator#5

@Mpdreamz Mpdreamz marked this pull request as ready for review November 17, 2020 19:54
@Mpdreamz Mpdreamz added enhancement New feature or request v0.7.0 labels Nov 17, 2020
Copy link

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of the packages can be bumped to our latest releases but otherwise LGTM.

]
},
"release-notes": {
"version": "0.2.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could now use 0.3.0

]
},
"assembly-differ": {
"version": "0.11.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could now use 0.13.0

@Mpdreamz
Copy link
Contributor Author

Good catch @stevejgordon updated the tooling to latest too.

Copy link

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 53bdb39 into master Nov 18, 2020
@Mpdreamz Mpdreamz deleted the fix/move-to-common-build branch November 18, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v0.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants