-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/move to common build #5
Conversation
The dependency listing turned out be a bug in |
d43a854
to
2684a31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of the packages can be bumped to our latest releases but otherwise LGTM.
dotnet-tools.json
Outdated
] | ||
}, | ||
"release-notes": { | ||
"version": "0.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could now use 0.3.0
dotnet-tools.json
Outdated
] | ||
}, | ||
"assembly-differ": { | ||
"version": "0.11.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could now use 0.13.0
Good catch @stevejgordon updated the tooling to latest too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This moves the build over to the common build pattern in nullean, ecs-dotnet, elastic-transport.
Moves the SDK over to .NET 5.0
This now no longer hides
System.Reactive
, the build had to be run under windows for ILRepack to work and properly resign. Dependency free is nice but not worth spending weeks over trying to get there.This also bumps the base TFM to net461 this falls in line with other repositories