Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report the first statement of the ones that can be combined in an Assert.Multiple #555

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

manfred-brands
Copy link
Member

Fixes #541

Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took some time to review this, but this week has been fully booked. The change looks sound (although I probably need to work with UseAssertMultipleAnalyzer to fully get the logic). I'm happy to merge this when you are (and again thanks for the work @manfred-brands).

Ps. Can you see issue with creating a release this weekend ?

@manfred-brands manfred-brands merged commit b53185d into nunit:master Jun 10, 2023
@manfred-brands manfred-brands deleted the issue/541 branch June 10, 2023 13:33
@manfred-brands
Copy link
Member Author

Thanks @mikkelbu
It should be fine to create a release now.
I won't be able to get to anything for a while.

@mikkelbu mikkelbu added this to the Release 3.7 / 2.7 milestone Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NUnit2045] Incorrect refactoring
2 participants