Porting Tasks branch to Master branch #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated UG and DG for addTask + addDeadline
* Modified aboutUs page: Ks * Updated UG and DG for viewDate + selectDate
Most of the code in our the code base only puts a single space between
non-whitespace characters,
"Like " + "this."
It is highly likely that there will not be a case where we will need to
put more than a single space between non-whitespace characters,
"Like " + "this."
To enforce consistency throughout the code base, let's add the
SingleSpaceSeparator module to our checkstyle configuration, and fix all
of the existing violations in our code base.
When run in head-full mode, HelpWindowTest fails with the following
exception:
seedu.address.ui.HelpWindowTest > focus_helpWindowNotFocused_focused FAILED
java.lang.AssertionError at HelpWindowTest.java:64
The line in question is from the following:
assertFalse(helpWindow.getRoot().isFocused());
which comes right after:
// Focus on another stage to remove focus from the helpWindow
FxToolkit.setupStage(Stage::requestFocus);
However, despite what the comment claims, the call to
FxToolkit.setupStage(...) does not "focus on another stage". This is
because the Stage registered with TestFX is the HelpWindow stage itself.
In other words, we are just requesting the HelpWindow to focus itself,
which is the complete opposite of "removing focus from the helpWindow".
This "focus on another stage" code was written in 1c6071f
(HelpWindowTest: fix failing test in non-headless mode, 2018-04-16). At
that point in time, the stage registered with TestFX _was_ "another
stage"[1] and so the code was correct. However, in a42eded (Fix
stalling HelpWindowTest, 2018-06-26) this was changed such that the
stage registered with TestFX is the HelpWindow stage itself. Yet, the
code was not modified to properly operate in the new world order[2].
Fix this piece of code by creating a temporary stage to focus on, so
that the goal of "removing focus from the helpWindow" is properly
achieved.
[1]: Somewhat-ish. The full story can be found in a42eded (Fix stalling
HelpWindowTest, 2018-06-26).
[2]: And obviously, the author did not run tests in head-full mode :-S
Modified comments to avoid checkstyle errors
* Modified aboutUs page: Ks * Updated UG and DG for viewDate + selectDate
Fixed checkstyles issues & removed checkstyleTest from travis check
Added Deadline Class + SelectDeadline
Added Milestone class and AddMilestoneCommand feature
…into MileStoneV1.2 # Conflicts: # src/main/java/seedu/address/logic/LogicManager.java # src/main/java/seedu/address/logic/parser/CliSyntax.java # src/main/java/seedu/address/logic/parser/TaskBookParser.java # src/test/java/seedu/address/logic/parser/TaskBookParserTest.java
With the unrefactored folders + Modified changes for SelectDeadline &…
Resolving EOF bug [Travis]
…nent of DeferDeadlineCommand
…into MileStoneV1.2
Fixed checkstyle and moved main/java/../unrefactored folder
|
Hi @chelseyong, your pull request title is invalid. For PR sent to satisfy a learning outcome, the PR name should be in the format of For team PR, the PR name should be in the format of Please follow the above format strictly and edit your title for reprocessing. Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR. |
auskure
pushed a commit
to auskure/main
that referenced
this pull request
Nov 3, 2018
Refactoring andupdate of UG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.