Use Unicode words for movement #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also skips multiple consecutive non-word characters (word boundaries) as part of the movement in a similar way to how bash/readline do it.
basile-henry
commented
Mar 7, 2021
| } | ||
| } | ||
|
|
||
| /// Match any sequence of characters that are considered a word boundary | ||
| fn is_word_boundary(s: &str) -> bool { | ||
| !s.chars().any(char::is_alphanumeric) |
There was a problem hiding this comment.
Note: This logic to identify a str as being a word boundary or not is copied from unicode-segmentation as it doesn't seem to be exposed as part of the public API.
There was a problem hiding this comment.
Seems okay. We might want to put an issue on unicode-segmentation and ask if they'd be willing to make it public (if you haven't already)
|
Looks good. thanks for simplifying the logic, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also makes word movement skip multiple consecutive non-word characters (word boundaries) in a similar way to how bash/readline do it.