perf(cpex): course lookup with map instead of linear search (#3685)

nusmodifications · Mar 27, 2024 · 711a6da · 711a6da
1 parent b20b4ce
commit 711a6da
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/website/src/views/mpe/form/MpeFormContainer.tsx b/website/src/views/mpe/form/MpeFormContainer.tsx
@@ -25,19 +25,18 @@ const MpeFormContainer: React.FC<Props> = ({ getSubmission, updateSubmission })
     Promise.all([fetchMpeModuleList(), getSubmission()])
       .then(([fetchedMpeModuleList, fetchedSubmission]) => {
         setMpeModuleList(fetchedMpeModuleList);
+        const moduleLookup = new Map(
+          fetchedMpeModuleList.map((module) => [module.moduleCode, module]),
+        );
         setSubmission({
           ...fetchedSubmission,
           // Replace data fetched from MPE server with latest data from MPE module list
-          // TODO: Optimize. This does an linear time lookup for each preference
           preferences: fetchedSubmission.preferences.map((preference) => {
-            const mpeModule = fetchedMpeModuleList.find(
-              (m) => m.moduleCode === preference.moduleCode,
-            );
+            const mpeModule = moduleLookup.get(preference.moduleCode);
             if (!mpeModule) return preference;
             return {
               ...preference,
               moduleTitle: mpeModule.title,
-              moduleCode: mpeModule.moduleCode,
               moduleCredits: parseInt(mpeModule.moduleCredit, 10),
             };
           }),