Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check nutanixmachine resources when deleting nutanixcluster #304

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

yannickstruyf3
Copy link
Contributor

@yannickstruyf3 yannickstruyf3 commented Aug 22, 2023

What this PR does / why we need it:

  • Wait for nutanixcluster deletion until all nutanixmachine resources are deleted
  • Retry nutanixcluster creation in case of category creation failure instead of raising fatal error.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
N/A

How Has This Been Tested?:

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

- Wait for nutanixcluster deletion until all nutanixmachine resources are deleted
- Retry nutanixcluster creation in case of category creation failure instead of raising fatal error. 

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Merging #304 (dec2a0b) into main (556905e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##            main    #304      +/-   ##
========================================
- Coverage   2.64%   2.62%   -0.02%     
========================================
  Files          4       4              
  Lines        982     989       +7     
========================================
  Hits          26      26              
- Misses       956     963       +7     
Files Changed Coverage Δ
controllers/nutanixcluster_controller.go 6.79% <0.00%> (-0.31%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to add test cases for the fixes?

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just nit

controllers/nutanixcluster_controller.go Show resolved Hide resolved
@nutanix-cn-prow-bot
Copy link

@yannickstruyf3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ncn-1-calico-k8s-v1.26.1 acb0d84 link false /test e2e-ncn-1-calico-k8s-v1.26.1

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thunderboltsid
Copy link
Contributor

/lgtm
/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, thunderboltsid, yannickstruyf3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,thunderboltsid,yannickstruyf3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuxtof tuxtof added the bug Something isn't working label Aug 28, 2023
@tuxtof tuxtof merged commit ab02fee into nutanix-cloud-native:main Aug 28, 2023
3 of 5 checks passed
@tuxtof tuxtof removed the request for review from deepakm-ntnx August 28, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants