New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Bump up Cluster API dependency version to v1.5.0 #311

Closed

thunderboltsid wants to merge 1 commit into main from capi-1.5

Contributor

thunderboltsid commented Aug 28, 2023 •

edited

Loading

Changes in this PR

Upgrade CAPI Library dependency tov1.5.0
Upgrade CAPI Component manifests for e2e to v1.5.0
Upgrade Kubernetes library versions to v0.27
Upgrade controller-runtime version to v0.15
Upgrade go version in go.mod and go install scripts to v1.21
Set minimum go version in go version ensure scripts to v1.20
Peg kind to v0.19 due to lack of cgroups v2 in our CI infra machines: The conformance test still seems to fail in CI (NKE clusters running CentOS 7) due to cgroupns being private which likely means that the conformance test is using another version of kind.
Upgrade ko version in Makefile to v0.15.1

How has this been tested?

$ LABEL_FILTERS="capx-feature-test"  make test-e2e-calico
...
Ran 14 of 31 Specs in 3286.188 seconds
SUCCESS! -- 14 Passed | 0 Failed | 0 Pending | 17 Skipped
PASS

Ginkgo ran 1 suite in 55m8.640549975s
Test Suite Passed

$ LABEL_FILTERS="conformance"  make test-e2e-calico
...
Ran 1 of 31 Specs in 1887.614 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 30 Skipped
PASS

Ginkgo ran 1 suite in 31m41.607584374s
Test Suite Passed

thunderboltsid force-pushed the capi-1.5 branch from efded79 to 2f9f76a Compare

August 28, 2023 15:41

deepakm-ntnx reviewed

View reviewed changes

go.mod Outdated Show resolved Hide resolved

thunderboltsid added the do-not-merge/work-in-progress label

thunderboltsid changed the title ~~Bump up Cluster API dependency version to v1.5.0~~ [WIP] Bump up Cluster API dependency version to v1.5.0

thunderboltsid force-pushed the capi-1.5 branch 2 times, most recently from dd69cb2 to 354324a Compare

August 28, 2023 16:54

nutanix-cn-prow-bot bot removed the do-not-merge/work-in-progress label

nutanix-cn-prow-bot bot requested review from adiantum and deepakm-ntnx

August 28, 2023 16:56

thunderboltsid force-pushed the capi-1.5 branch from 354324a to 469f090 Compare

August 28, 2023 17:02

Contributor Author

thunderboltsid commented Aug 28, 2023

/retest

thunderboltsid force-pushed the capi-1.5 branch from 469f090 to e30244d Compare

August 28, 2023 19:19

codecov-commenter commented Aug 28, 2023 •

edited by codecov bot

Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3226563) 10.99% compared to head (57cb259) 10.99%.
Report is 14 commits behind head on main.

Files	Patch %	Lines
controllers/nutanixmachine_controller.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   10.99%   10.99%           
=======================================
  Files           4        4           
  Lines        1046     1046           
=======================================
  Hits          115      115           
  Misses        931      931

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Contributor Author

thunderboltsid commented Aug 28, 2023

/retest

thunderboltsid force-pushed the capi-1.5 branch from e30244d to a64e3ed Compare

August 28, 2023 19:56

Contributor Author

thunderboltsid commented Aug 28, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

thunderboltsid force-pushed the capi-1.5 branch 3 times, most recently from c3f9a63 to 85a624d Compare

August 28, 2023 20:39

Contributor Author

thunderboltsid commented Aug 28, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

thunderboltsid added the do-not-merge/work-in-progress label

thunderboltsid force-pushed the capi-1.5 branch from 85a624d to e9bcfb0 Compare

August 28, 2023 21:09

Contributor Author

thunderboltsid commented Aug 28, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

thunderboltsid force-pushed the capi-1.5 branch 3 times, most recently from 6e959ce to 9d7455a Compare

August 28, 2023 22:31

Contributor Author

thunderboltsid commented Aug 28, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

thunderboltsid changed the title ~~[WIP] Bump up Cluster API dependency version to v1.5.0~~ Bump up Cluster API dependency version to v1.5.0

Contributor Author

thunderboltsid commented Aug 29, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

thunderboltsid removed the do-not-merge/work-in-progress label

Contributor

adiantum commented Aug 29, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

Contributor Author

thunderboltsid commented Aug 29, 2023

Need to bump up the base image for the prow job to ensure it works with cgroups v2 https://github.com/nutanix-cloud-native/prow-config/pull/49

thunderboltsid force-pushed the capi-1.5 branch from 9d7455a to 40539f6 Compare

August 29, 2023 13:14

Contributor Author

thunderboltsid commented Aug 29, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

thunderboltsid force-pushed the capi-1.5 branch from 40539f6 to 371af26 Compare

August 29, 2023 14:25

Contributor Author

thunderboltsid commented Aug 29, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

2 similar comments

Contributor Author

thunderboltsid commented Aug 29, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

Contributor Author

thunderboltsid commented Aug 29, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

thunderboltsid force-pushed the capi-1.5 branch from 371af26 to ee0bb64 Compare

August 29, 2023 16:25

Contributor Author

thunderboltsid commented Aug 29, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

tuxtof force-pushed the capi-1.5 branch from ee0bb64 to e93f9be Compare

August 29, 2023 16:56

Contributor Author

thunderboltsid commented Aug 29, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

2 similar comments

Contributor Author

thunderboltsid commented Aug 29, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

Contributor Author

thunderboltsid commented Aug 29, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

thunderboltsid changed the title ~~Bump up Cluster API dependency version to v1.5.0~~ [WIP] Bump up Cluster API dependency version to v1.5.0

thunderboltsid force-pushed the capi-1.5 branch 2 times, most recently from 0cd6402 to 22e883d Compare

August 30, 2023 16:14

Contributor Author

thunderboltsid commented Aug 30, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

2 similar comments

Contributor Author

thunderboltsid commented Aug 31, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

Contributor Author

thunderboltsid commented Aug 31, 2023

/test e2e-ncn-1-calico-k8s-v1.26.1

thunderboltsid force-pushed the capi-1.5 branch 2 times, most recently from 4ad4c36 to aa5652a Compare

December 8, 2023 15:22

Contributor Author

thunderboltsid commented Dec 8, 2023

/retest


          Bump up Cluster API dependency version to v1.5.4

57cb259

We should intend to keep this to latest released CAPI versions.

thunderboltsid force-pushed the capi-1.5 branch from aa5652a to 57cb259 Compare

December 8, 2023 15:34

github-actions bot commented Dec 8, 2023

✅ None of your dependencies violate policy!

nutanix-cn-prow-bot bot commented Dec 8, 2023

@thunderboltsid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ncn-1-calico-k8s-v1.26.1	`57cb259`	link	false	`/test e2e-ncn-1-calico-k8s-v1.26.1`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

thunderboltsid closed this

thunderboltsid deleted the capi-1.5 branch

February 23, 2024 09:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet