Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out busybox image to non-dockerhub #463

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

thunderboltsid
Copy link
Contributor

This is to ensure fewer rate limit issues via dockerhub.

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.34%. Comparing base (285483f) to head (7c292b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   32.34%   32.34%           
=======================================
  Files          17       17           
  Lines        1830     1830           
=======================================
  Hits          592      592           
  Misses       1217     1217           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid thunderboltsid added the ignore-for-release Internal change to not include in Release Notes label Jul 27, 2024
@tuxtof
Copy link
Contributor

tuxtof commented Jul 29, 2024

@thunderboltsid best is use a more official busybox image and not a random one coming from Prom project

we can go with cgr.dev/chainguard/busybox

This is to ensure fewer rate limit issues via dockerhub.
@thunderboltsid thunderboltsid changed the title Swap out busybox image to quay.io Swap out busybox image to non-dockerhub Aug 20, 2024
Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thunderboltsid thunderboltsid merged commit bf5ce6b into main Aug 20, 2024
9 of 11 checks passed
@thunderboltsid thunderboltsid deleted the issue/ghworkflow branch August 20, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Internal change to not include in Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants