Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CAPI to v1.8.1 #476

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Update CAPI to v1.8.1 #476

merged 1 commit into from
Aug 21, 2024

Conversation

thunderboltsid
Copy link
Contributor

  • Add a build-e2e target to
  • Clean up existing build target deps
  • refactor tests and controllers to match updated dependencies

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 32.56%. Comparing base (bf5ce6b) to head (58e345a).
Report is 1 commits behind head on main.

Files Patch % Lines
main.go 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
+ Coverage   32.34%   32.56%   +0.21%     
==========================================
  Files          17       17              
  Lines        1830     1833       +3     
==========================================
+ Hits          592      597       +5     
+ Misses       1217     1216       -1     
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tuxtof tuxtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thunderboltsid don't you need also to update devbox clusterctl dependency to 1.8.1 ??

@thunderboltsid
Copy link
Contributor Author

@thunderboltsid don't you need also to update devbox clusterctl dependency to 1.8.1 ??

nixpkgs don't have 1.8.1 yet only 1.8.0.

Run `make build`
@thunderboltsid thunderboltsid merged commit 5d63d09 into main Aug 21, 2024
9 of 11 checks passed
@thunderboltsid thunderboltsid deleted the issue/capi-1.8 branch August 21, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants