Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Optimize logic for detach VG from VM for cases with large number of VGs #477

Merged
merged 5 commits into from
Aug 25, 2024
Merged

fix(controller): Optimize logic for detach VG from VM for cases with large number of VGs #477

merged 5 commits into from
Aug 25, 2024

Commits on Aug 24, 2024

  1. fix(controller): Fail waitForV4Task on context timeout and terminal s… 

    …tates

The polling will now fail after 1 minute or if task returned has a terminal
state of FAILED or CANCELLED.
    @thunderboltsid
    thunderboltsid committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b46a831 View commit details
    Browse the repository at this point in the history

  2. parallelize waiting

    @thunderboltsid
    thunderboltsid committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    8fcc2d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. switch polling logic out of goroutines and check them all in a loop

    @thunderboltsid
    thunderboltsid committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    84f95bc View commit details
    Browse the repository at this point in the history

  2. Stop waiting on detachVG altogether

    @thunderboltsid
    thunderboltsid committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    d138363 View commit details
    Browse the repository at this point in the history

  3. Add a log for the requeue

    @thunderboltsid
    thunderboltsid committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    69f7b5b View commit details
    Browse the repository at this point in the history