Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend union support #2462

Closed
jsvdvis opened this issue Nov 3, 2023 · 0 comments · Fixed by #2468
Closed

Extend union support #2462

jsvdvis opened this issue Nov 3, 2023 · 0 comments · Fixed by #2468
Labels
enhancement A feature or improvement

Comments

@jsvdvis
Copy link
Contributor

jsvdvis commented Nov 3, 2023

What problem does this feature proposal attempt to solve?
As far as I can see, the package currently does not support extending unions. The syntax is parsed but silently ignored near https://github.com/nuwave/lighthouse/blob/master/src/Schema/AST/ASTBuilder.php#L122.

Am I missing something here? Is there a specific reason this is the case?

Which possible solutions should be considered?

If there is no specific reason that this is ignored, I am willing to write a PR for this, though this might take me a while. If there are specific things I should keep in mind when doing this, please let me know.
@jsvdvis jsvdvis mentioned this issue Nov 13, 2023
Merged
3 tasks
@spawnia spawnia added the enhancement A feature or improvement label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend union support belsimpel/lighthouse
2 participants
@spawnia @jsvdvis