Extend union support #2468
Merged
Extend union support #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing phpstan check is likely due to a recent phpstan package update and unrelated to my changes (unless I am missing something). |
spawnia
previously approved these changes
Nov 28, 2023
|
Thank you, could you please resolve conflicts so this can be merged? |
# Conflicts: # CHANGELOG.md
|
The conflicts should be resolved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2462
Changes
This MR adds support for extending unions. The
extend unionsyntax was already supported by the parser, but was not yet implemented in theASTBuilder.Breaking changes
Code that already uses the syntax might expect it to silently be ignored, which is no longer the case with this MR. People should not depend on this and thus I do not think it is worth mentioning in the documentation. If someone disagrees and has an idea where this should be mentioned, please let me know.