Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crashes with explicit nulls on arg directives #2446

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Prevent crashes with explicit nulls on arg directives #2446

merged 4 commits into from
Sep 18, 2023

Conversation

MissaelAnda
Copy link
Contributor

Same as #2444 for more ArgDirectives

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

  • Explicit nulls are ignored in directives @notIn @whereBetween and @whereNotBetween.
  • @where directive has now the ignoreNull argument so the user can explicitly tell when to ignore null values.

Breaking changes
No

spawnia
spawnia requested changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extract the changes to @where to a separate merge request so we can discuss it there. I am fine with the rest of the changes.

tests/Integration/Schema/Directives/NotInDirectiveTest.php Outdated Show resolved Hide resolved
tests/Integration/Schema/Directives/NotInDirectiveTest.php Outdated Show resolved Hide resolved
tests/Integration/Schema/Directives/WhereBetweenDirectiveTest.php Outdated Show resolved Hide resolved
tests/Integration/Schema/Directives/WhereDirectiveTest.php Outdated Show resolved Hide resolved
tests/Integration/Schema/Directives/WhereDirectiveTest.php Outdated Show resolved Hide resolved
tests/Integration/Schema/Directives/WhereNotBetweenDirectiveTest.php Outdated Show resolved Hide resolved
MissaelAnda and others added 3 commits September 15, 2023 13:18
@MissaelAnda
requested tests changes
3bb6b49
@MissaelAnda
reverted where directive change
fa4c29a
@MissaelAnda @spawnia
cleaner test
405b187 
Co-authored-by: Benedikt Franke <benedikt@franke.tech>
@spawnia spawnia added the bug An error within Lighthouse label Sep 18, 2023
@spawnia spawnia merged commit de25722 into nuwave:master Sep 18, 2023
24 checks passed
@spawnia
Copy link
Collaborator

spawnia commented Sep 18, 2023

Thank you, released with https://github.com/nuwave/lighthouse/releases/tag/v6.18.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spawnia spawnia spawnia requested changes

Assignees
No one assigned
Labels
bug An error within Lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MissaelAnda @spawnia