Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): lock nanoid in v2.1.11 #751

Closed
wants to merge 1 commit into from
Closed

chore(deps): lock nanoid in v2.1.11 #751

wants to merge 1 commit into from

Conversation

JoaoPedroAS51
Copy link
Collaborator

Fixes nanoid import for auth module v4

Fixes #750

@JoaoPedroAS51 JoaoPedroAS51 requested a review from pi0 July 1, 2020 20:58
@JoaoPedroAS51 JoaoPedroAS51 changed the base branch from dev to master July 1, 2020 20:58
@0-M
Copy link

0-M commented Jul 20, 2020

I'd recommend fixing the import if possible:

import { nanoid } from 'nanoid'

vs

import nanoid from 'nanoid'

@bmulholland bmulholland mentioned this pull request Dec 8, 2020
Merged
@bmulholland
Copy link
Contributor

Superseded by #906

@bmulholland bmulholland closed this Dec 8, 2020
@bmulholland bmulholland deleted the chore/nanoid-2.1.11 branch December 8, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$auth.loginWith() not working
3 participants
@JoaoPedroAS51 @0-M @bmulholland