feat: set baseUrl
via runtimeConfig
#1920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#1908
β Type of change
π Description
baseUrl
viaruntimeConfig
Β #1908Allows us to set the
baseUrl
viaruntimeConfig
as follows:This way the
baseUrl
can be overwritten by setting theNUXT_PUBLIC_I18N_BASE_URL
environment variable, which makes it easier to deploy from development, to staging and production environments without rebuilding or making changes to code.I added some debug logs for easier debugging which configuration is being used to set the
baseUrl
.The current implementation works by settings
public.i18n.baseUrl
, if there is a preference to have it in the secret/privateruntimeConfig
instead I can change it accordingly. Because of this I haven't added documentation to this PR yet.There may be other configurations we could also add
runtimeConfig
support for, I'll keep that in mind when adding documentation if this feature gets approved.π Checklist