Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazy load locales #2294

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Aug 3, 2023

πŸ”— Linked issue

#2192

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #2192
Resolves #1875

Since #2290 has been merged, we have the full file paths of each locale similar to the keys used in the manifest hook. Allowing us to accurately change only those entries by their path.

The test I wrote in #2292 has been enabled and expanded on in this PR.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Aug 3, 2023
@BobbieGoede BobbieGoede force-pushed the fix/lazy-load-locales-concept branch 3 times, most recently from 01d783d to 67a6be9 Compare August 13, 2023 11:22
@BobbieGoede BobbieGoede changed the title fix: lazy load locales - concept fix: lazy load locales Aug 26, 2023
@BobbieGoede BobbieGoede marked this pull request as ready for review August 26, 2023 07:19
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great works!
Thank you! ❀️

@kazupon kazupon merged commit 3a5226f into nuxt-modules:next Aug 26, 2023
4 checks passed
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
* chore(deps): update nuxt dependencies to v3.7.0

* fix: disable prefetching lazy locales
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lazy load files not working Prefetch & preload issues
2 participants