-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: remove deprecated legacy dynamic route params #2801
chore!: remove deprecated legacy dynamic route params #2801
Conversation
β Live Preview ready!
|
Thank you! I had planned to drop features in v8.1 that I had marked as deprecated prior to the v8.0 release. So I believe that if we drop deprecation, we should release as v9. There may be other deprecations in nuxt i18n. |
I agree, I'll label it v9 and set it to draft. It's good to be careful with breaking changes, I think with some planning it can be combined with some other changes. Maybe I'll open an issue/discussion for v9 in the coming days to track which issues/changes could be included so users can give feedback or suggest changes. |
Good idea! π |
3ea37e1
to
e19819e
Compare
@kazupon Related to this feature, should we also remove |
a3c9d1c
to
c426492
Compare
34c589a
to
d2fa9e6
Compare
π Linked issue
β Type of change
π Description
The deprecation of using
nuxtI18n
withdefinePageMeta
was a bit soft, as we kept using the same key internally forsetI18nParams
I can imagine there may have been users ignoring the warning. I changed thenuxtI18n
key tonuxtI18nInternal
, this will break the functionality for projects using the deprecated functionality and better communicate that this is an internal key.At some point we may or may not move away from using the
meta
key on routes, this is already the case when havingexperimental.switchLocalePathLinkSSR
feature enabled.π Checklist