Skip to content

Commit

Permalink
Fix OSX mypy errors (#884)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jacobfaib committed Nov 15, 2023
1 parent 6fa0acc commit 74244e7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
3 changes: 1 addition & 2 deletions legate/tester/stages/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
from __future__ import annotations

import sys
from typing import Dict, Type

from .. import FeatureType
from .test_stage import TestStage
Expand All @@ -33,7 +32,7 @@
raise RuntimeError(f"unsupported platform: {sys.platform}")

#: All the available test stages that can be selected
STAGES: Dict[FeatureType, Type[TestStage]] = {
STAGES: dict[FeatureType, type[TestStage]] = {
"cpus": CPU,
"cuda": GPU,
"openmp": OMP,
Expand Down
9 changes: 8 additions & 1 deletion legate/tester/stages/_osx/gpu.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@
from typing import TYPE_CHECKING

from ..test_stage import TestStage
from ..util import UNPIN_ENV, Shard
from ..util import UNPIN_ENV

if TYPE_CHECKING:
from ....util.types import ArgList, EnvDict
from ... import FeatureType
from ...config import Config
from ...test_system import TestSystem
from ..util import Shard, StageSpec


class GPU(TestStage):
Expand Down Expand Up @@ -52,3 +53,9 @@ def env(self, config: Config, system: TestSystem) -> EnvDict:

def delay(self, shard: Shard, config: Config, system: TestSystem) -> None:
time.sleep(config.gpu_delay / 1000)

def shard_args(self, shard: Shard, config: Config) -> ArgList:
raise NotImplementedError()

def compute_spec(self, config: Config, system: TestSystem) -> StageSpec:
raise NotImplementedError()

0 comments on commit 74244e7

Please sign in to comment.