Add a launcher option to the tester #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinz
added
the
category:improvement
|
@marcinz this looks good, if you are interested there are some pure unit tests for the tester itself that could probably be updated: https://github.com/nv-legate/legate.core/tree/branch-23.09/tests/unit/legate/tester These are run with plain |
|
@bryevdv If the tests look good and you approve, then I'll merge. |
bryevdv
reviewed
Oct 6, 2023
mag1cp1n
added a commit
to mag1cp1n/legate.core
that referenced
this pull request
Oct 17, 2023
bryevdv
approved these changes
Oct 17, 2023
bryevdv
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tester needs to know about the
--launchercommand line option for multi-rank testing.