Skip to content

Commit

Permalink
Revert "NVDAObjects.UIA: provide a base implementation of UIA item st…
Browse files Browse the repository at this point in the history
…atus property event (#14080)" (#14136)

This reverts commit a4644ef.

This reverts commit a4644ef.

Link to issue number:
reverts #14080
re-opens #13973

Summary of the issue:
Based on discussion in #14086 (comment), it appears that #14080 makes the behaviour worse when using WPF projects in VS.

Description of user facing changes
#13973 is now an issue again

Description of development approach
reverts #14080
  • Loading branch information
seanbudd authored Sep 14, 2022
1 parent aaa0fd1 commit 3219514
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
12 changes: 0 additions & 12 deletions source/NVDAObjects/UIA/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2043,18 +2043,6 @@ def event_UIA_notification(self, notificationKind=None, notificationProcessing=U
speech.cancelSpeech()
ui.message(displayString)

_itemStatusCache = None

def event_UIA_itemStatus(self):
"""
Base implementation of UIA item status property event.
By default NVDA will announce element name and item status if any.
"""
itemStatus = self.UIAElement.currentItemStatus
if itemStatus and itemStatus != self._itemStatusCache:
ui.message(f"{self.name} {itemStatus}")
self._itemStatusCache = itemStatus

def event_UIA_dragDropEffect(self):
# UIA drag drop effect was introduced in Windows 8.
try:
Expand Down
1 change: 0 additions & 1 deletion user_docs/en/changes.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ Note there are still known issues with Chrome and Edge. (#13254)
- Touch screen interaction should now be accurate for most applications. (#7083)
- Mouse tracking should now work for most applications. (#6722)
-
- NVDA will announce UIA item status property changes in places such as the Visual Studio 2022 create app packages dialog. (#13973)
- Orientation state (landscape/portrait) changes are now correctly ignored when there is no change (e.g. monitor changes). (#14035)
- NVDA will announce dragging items on screen in places such as rearranging Windows 10 Start menu tiles and virtual desktops in Windows 11. (#12271, #14081)
-
Expand Down

0 comments on commit 3219514

Please sign in to comment.