-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an article role and allow quick navigation to articles #10424
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Just did a quick test with the UIA implementation of Edge Chromium. There, it looks like the aria role of article will be properly exposed, even when using the |
"""Adds a script for the given quick nav item. | ||
@param itemType: The type of item, I.E. "heading" "Link" ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this line removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, that must have been an accident. Restoring now.
In the current implementation, the "out of article" sentence is also spoken when leaving articles. For landmarks, this isn't the case. While landmarks and articles aren't the same, I feel they should behave equivalent in this case. Thus, either they should announce exit, or they shouldn't. See also #10420 |
Link to issue number:
Fixes #9227
Summary of the issue:
It has been a long standing request to allow quick navigation from/to articles. Also, articles should be able to mentioned as such.
Description of how this pull request fixes the issue:
Testing performed:
Tested the following in Firefox, Chrome and IE:
Known issues with pull request:
The implementation for EdgeHTML is limited in that it works for nodes that have been marked up with the aria role of article. Articles marked up as such with the
<article>
tag aren't recognized, because they have the grouping role and the only way to detect whether it's an article is by means of theLocalizedControlType
. Bah!Change log entry: