When NVDA config path is overwritten from the command line open actual config dir when using a keyboard command #10911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into account when opening config directory
|
@feerrenrut I'd appreciate your review when time permits. |
feerrenrut
suggested changes
Mar 30, 2020
|
@feerrenrut Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Discussion in #10493
Summary of the issue:
If NVDA config path is overwritten from the command line and user tries to open configuration directory by pressing keyboard command wrong folder is opened,
Description of how this pull request fixes the issue:
If possible globalVars.appArgs.configPath is used to retrieve actual config path falling back to config.getUserDefaultConfigPath() if not.
Testing performed:
Ensured that when the config path is specified on the command line and the script to open config path is executed proper folder opens.
Known issues with pull request:
None known
Change log entry:
None needed this is not in a release yet.